Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Atmos leak fix #1663

Merged
merged 4 commits into from
Nov 14, 2014
Merged

Atmos leak fix #1663

merged 4 commits into from
Nov 14, 2014

Conversation

digitaldan
Copy link
Contributor

This attempts to fix #765
Hi guys, I added a quick fix which checks for dead entries in a Map before it adds any more. I ran this for a few days and it seems to works, heap dumps show we are no longer growing this structure. I was planning on adding a executor or something along those lines to do this at a scheduled interval, but this has been working so well I'm not sure its worth the extra complication (starting, stopping and cleaning up something). A listener for when these resources expire ( like a session listener in a servlet container) would be nice, but I could not find an obvious way to do that reliably.

I do want to say this is not something usually I'm comfortable doing, I feel like the little Dutch boy sticking his fingers in the dyke trying to stop each leak! Unfortunately the atmosphere framework has beaten me ;-), at least how its being used now. But since we know its not a long term solution for openHAB, I'll keep poking away.

@teichsta teichsta added this to the 1.6.0 milestone Nov 14, 2014
teichsta added a commit that referenced this pull request Nov 14, 2014
@teichsta teichsta merged commit de3d04b into openhab:master Nov 14, 2014
@teichsta
Copy link
Member

thanks a million, Dan!

@buildhive
Copy link

openhab » openhab #1592 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@digitaldan
Copy link
Contributor Author

I'm testing something over night, hopefully I will have a PR tomorrow.

@teichsta
Copy link
Member

great, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Losing events on REST API (atmosphere)
3 participants